From c3b24fdd323caf9c7a2e07cb486f2e303e17322c Mon Sep 17 00:00:00 2001 From: Yurun Date: Thu, 23 Jul 2026 21:37:26 +0800 Subject: [PATCH 1/6] =?UTF-8?q?fix(compiler):=20=E4=BF=AE=E5=A4=8D?= =?UTF-8?q?=E8=BF=94=E5=9B=9E=E7=B1=BB=E5=9E=8B=E5=8D=8F=E5=8F=98=E6=A3=80?= =?UTF-8?q?=E6=9F=A5?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- src/Translator.php | 130 ++++++++++++++++-- .../class/interface-return-covariance.phpt | 47 +++++++ .../type_decl/return-type-covariance.phpt | 51 +++++++ 3 files changed, 218 insertions(+), 10 deletions(-) create mode 100644 tests/compiler/class/interface-return-covariance.phpt create mode 100644 tests/compiler/type_decl/return-type-covariance.phpt diff --git a/src/Translator.php b/src/Translator.php index 14916aec..8d36035f 100644 --- a/src/Translator.php +++ b/src/Translator.php @@ -3717,25 +3717,135 @@ CODE; if ($childFuncDef->returnTypeUndeclared) { return false; } - if ($parentFuncDef->returnTypeCheck || $childFuncDef->returnTypeCheck) { - return $parentFuncDef->returnTypeStr === $childFuncDef->returnTypeStr; - } + // A parent that accepts everything (mixed/var) is compatible with any + // child return type. if ($parentFuncDef->returnType === Type::VAR) { return true; } - if ($childFuncDef->returnType !== $parentFuncDef->returnType) { - return false; + + $parentTypes = $this->getReturnAcceptedTypes($parentFuncDef); + $childTypes = $this->getReturnAcceptedTypes($childFuncDef); + + // Return type covariance: every value the child can return must also be + // acceptable under the parent's declared return type. This allows a + // child to narrow a nullable/union return type (e.g. `?Base` -> `?Child` + // or `int|string` -> `int`) while still satisfying the parent contract. + return $this->isReturnTypeSubtype($childTypes, $parentTypes); + } + + private function getReturnAcceptedTypes(FunctionDef $functionDef): array + { + if (!empty($functionDef->returnTypeCheck)) { + return $functionDef->returnTypeCheck; } - if ($parentFuncDef->returnType !== Type::OBJECT) { - return true; + $type = $functionDef->returnType; + if ($type === Type::VAR) { + return [['kind' => 'isMixed']]; + } + if ($type === Type::OBJECT) { + return $functionDef->returnClass + ? [['kind' => 'instanceof', 'class' => $functionDef->returnClass]] + : [['kind' => 'isObject']]; + } + return match ($type) { + Type::INT => [['kind' => 'isInt']], + Type::FLOAT => [['kind' => 'isFloat']], + Type::BOOL => [['kind' => 'isBool']], + Type::STR => [['kind' => 'isString']], + Type::ARRAY => [['kind' => 'isArray']], + Type::RESOURCE => [['kind' => 'isResource']], + default => [['kind' => 'isMixed']], + }; + } + + private function isReturnTypeSubtype(array $childTypes, array $parentTypes): bool + { + foreach ($childTypes as $childType) { + if (!$this->isReturnTypeCoveredBy($childType, $parentTypes)) { + return false; + } } - if ($childFuncDef->returnClass === $parentFuncDef->returnClass) { + return true; + } + + private function isReturnTypeCoveredBy(array $childType, array $parentTypes): bool + { + $childKind = $childType['kind'] ?? null; + + // Child is an intersection (A&B): it is a subtype only if every member + // is individually a subtype of the parent type. + if ($childKind === 'allOf') { + foreach ($childType['types'] as $member) { + if (!$this->isReturnTypeCoveredBy($member, $parentTypes)) { + return false; + } + } return true; } - if (!$childFuncDef->returnClass || !$parentFuncDef->returnClass) { + + foreach ($parentTypes as $parentType) { + $parentKind = $parentType['kind'] ?? null; + + // Parent is an intersection (A&B): the child must be a subtype of + // every member of the intersection. + if ($parentKind === 'allOf') { + $ok = true; + foreach ($parentType['types'] as $member) { + if (!$this->isReturnTypeCoveredBy($childType, [$member])) { + $ok = false; + break; + } + } + if ($ok) { + return true; + } + continue; + } + + if ($this->isReturnTypeEntryCompatible($childKind, $childType, $parentKind, $parentType)) { + return true; + } + } + + return false; + } + + private function isReturnTypeEntryCompatible( + ?string $childKind, + array $childType, + ?string $parentKind, + array $parentType + ): bool { + if ($childKind === 'isNull') { + // A null value is only compatible with a nullable (isNull) parent. + return $parentKind === 'isNull'; + } + if ($childKind === 'isObject') { + // Any object is compatible with a parent that accepts any object. + return $parentKind === 'isObject'; + } + if ($childKind === 'isMixed') { + return $parentKind === 'isMixed'; + } + if ($childKind === 'instanceof') { + if ($parentKind === 'isObject') { + return true; + } + if ($parentKind === 'instanceof') { + $childClass = $childType['class'] ?? ''; + $parentClass = $parentType['class'] ?? ''; + if ($childClass === '' || $parentClass === '' || $childClass === 'static' || $parentClass === 'static') { + return false; + } + if ($childClass === $parentClass) { + return true; + } + return $this->isInheritedFrom($childClass, $parentClass); + } return false; } - return $this->isInheritedFrom($childFuncDef->returnClass, $parentFuncDef->returnClass); + // Scalar kinds must match exactly. + return $childKind === $parentKind; } private function isParameterTypeOverrideCompatible(ArgInfo $childArg, ArgInfo $parentArg): bool diff --git a/tests/compiler/class/interface-return-covariance.phpt b/tests/compiler/class/interface-return-covariance.phpt new file mode 100644 index 00000000..792c3c76 --- /dev/null +++ b/tests/compiler/class/interface-return-covariance.phpt @@ -0,0 +1,47 @@ +--TEST-- +Interface return type covariance with nullable interface and anonymous class +--FILE-- +test(); + var_dump($result instanceof TestInterface1); + var_dump($result instanceof TestInterface2); + var_dump($result === null); +} +?> +--EXPECT-- +bool(true) +bool(true) +bool(false) diff --git a/tests/compiler/type_decl/return-type-covariance.phpt b/tests/compiler/type_decl/return-type-covariance.phpt new file mode 100644 index 00000000..3de3e6bb --- /dev/null +++ b/tests/compiler/type_decl/return-type-covariance.phpt @@ -0,0 +1,51 @@ +--TEST-- +Return type covariance: union narrowing and object subtype +--FILE-- + int) is allowed. + public function make(): int + { + return 42; + } +} + +class BaseType {} +class ChildType extends BaseType {} + +interface ObjectReturnContract +{ + public function build(): BaseType; +} + +class ObjectReturnImpl implements ObjectReturnContract +{ + // Covariant: returning a subtype (ChildType) for a BaseType return is allowed. + public function build(): ChildType + { + return new ChildType(); + } +} + +function main() +{ + $impl = new UnionReturnImpl(); + var_dump($impl->make()); + + $obj = new ObjectReturnImpl(); + $built = $obj->build(); + var_dump($built instanceof BaseType); + var_dump($built instanceof ChildType); +} +?> +--EXPECT-- +int(42) +bool(true) +bool(true) From a3d8f57ef44c485b28d9b8cdba2599a29c50472f Mon Sep 17 00:00:00 2001 From: Yurun Date: Thu, 23 Jul 2026 21:38:29 +0800 Subject: [PATCH 2/6] =?UTF-8?q?fix(compiler):=20=E4=BF=AE=E5=A4=8D?= =?UTF-8?q?=E5=91=BD=E5=90=8D=E7=A9=BA=E9=97=B4=E5=B0=BE=E9=83=A8=E6=9C=89?= =?UTF-8?q?=E6=B3=A8=E9=87=8A=E5=AF=BC=E8=87=B4=E7=BC=96=E8=AF=91=E4=B8=8D?= =?UTF-8?q?=E9=80=9A=E8=BF=87?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- src/Preprocessor.php | 2 ++ src/Translator.php | 2 ++ .../namespace/namespace-ending-comment.phpt | 22 +++++++++++++++++++ 3 files changed, 26 insertions(+) create mode 100644 tests/compiler/namespace/namespace-ending-comment.phpt diff --git a/src/Preprocessor.php b/src/Preprocessor.php index 2d311e00..9e0d5d11 100644 --- a/src/Preprocessor.php +++ b/src/Preprocessor.php @@ -321,6 +321,8 @@ class Preprocessor extends CompilerBase case 'Stmt_Interface': $this->parseInterface($v2); break; + case 'Stmt_Nop': + break; default: $this->foundStrayCode($v2); break; diff --git a/src/Translator.php b/src/Translator.php index 14916aec..402568ea 100644 --- a/src/Translator.php +++ b/src/Translator.php @@ -2514,6 +2514,8 @@ CODE; case 'Stmt_Interface': $this->validateInterfaceOverrideAttributes($v2); break; + case 'Stmt_Nop': + break; default: abort($v2); break; diff --git a/tests/compiler/namespace/namespace-ending-comment.phpt b/tests/compiler/namespace/namespace-ending-comment.phpt new file mode 100644 index 00000000..fa0f3da0 --- /dev/null +++ b/tests/compiler/namespace/namespace-ending-comment.phpt @@ -0,0 +1,22 @@ +--TEST-- +A namespace block ending with a comment must not be treated as stray code +--FILE-- + +--EXPECT-- +string(4) "done" From 9cdc8b1b091c42fcfbbbc5f8d46d19e22d279bbf Mon Sep 17 00:00:00 2001 From: Yurun Date: Thu, 23 Jul 2026 21:41:24 +0800 Subject: [PATCH 3/6] =?UTF-8?q?fix(compiler):=20=E6=A3=80=E6=9F=A5?= =?UTF-8?q?=E6=9E=84=E9=80=A0=E5=87=BD=E6=95=B0=E5=8F=AF=E8=A7=81=E6=80=A7?= =?UTF-8?q?=E4=BB=A5=E9=98=B2=E6=AD=A2=E9=9D=9E=E6=B3=95=E8=B0=83=E7=94=A8?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../code/constructor_visibility_private.php | 11 ++++ .../code/constructor_visibility_protected.php | 11 ++++ ...tor_visibility_protected_foreign_class.php | 19 +++++++ phpunit/code/trait_constructor_conflict.php | 29 ++++++++++ phpunit/code/trait_constructor_private.php | 21 +++++++ phpunit/code/trait_constructor_protected.php | 21 +++++++ phpunit/src/ConstructorVisibilityTest.php | 57 +++++++++++++++++++ src/CompilerBase.php | 42 ++++++++++++++ .../ctor-visibility-protected-subclass.phpt | 26 +++++++++ tests/compiler/trait/trait-ctor-basic.phpt | 27 +++++++++ tests/compiler/trait/trait-ctor-override.phpt | 32 +++++++++++ .../trait/trait-ctor-protected-subclass.phpt | 37 ++++++++++++ .../compiler/trait/trait-ctor-with-args.phpt | 30 ++++++++++ 13 files changed, 363 insertions(+) create mode 100644 phpunit/code/constructor_visibility_private.php create mode 100644 phpunit/code/constructor_visibility_protected.php create mode 100644 phpunit/code/constructor_visibility_protected_foreign_class.php create mode 100644 phpunit/code/trait_constructor_conflict.php create mode 100644 phpunit/code/trait_constructor_private.php create mode 100644 phpunit/code/trait_constructor_protected.php create mode 100644 phpunit/src/ConstructorVisibilityTest.php create mode 100644 tests/compiler/object_ctor/ctor-visibility-protected-subclass.phpt create mode 100644 tests/compiler/trait/trait-ctor-basic.phpt create mode 100644 tests/compiler/trait/trait-ctor-override.phpt create mode 100644 tests/compiler/trait/trait-ctor-protected-subclass.phpt create mode 100644 tests/compiler/trait/trait-ctor-with-args.phpt diff --git a/phpunit/code/constructor_visibility_private.php b/phpunit/code/constructor_visibility_private.php new file mode 100644 index 00000000..89f7c1aa --- /dev/null +++ b/phpunit/code/constructor_visibility_private.php @@ -0,0 +1,11 @@ +compile($file); + } catch (TestError | \RuntimeException $exception) { + $this->assertStringContainsString($expected, $exception->getMessage()); + return; + } + $this->fail('Expected compile-time error was not thrown'); + } + + public function testPrivateConstructorCannotBeCalledFromOutside(): void + { + // 私有构造器不能从类外部通过 `new` 调用 + $this->exec('Cannot call private TestClass::__construct()', 'constructor_visibility_private.php'); + } + + public function testProtectedConstructorCannotBeCalledFromGlobalScope(): void + { + // 保护构造器不能从全局作用域调用 + $this->exec('Cannot call protected TestClass::__construct()', 'constructor_visibility_protected.php'); + } + + public function testProtectedConstructorCannotBeCalledFromNonSubclass(): void + { + // 保护构造器不能从非子类的其它类内部调用 + $this->exec('Cannot call protected Base::__construct()', 'constructor_visibility_protected_foreign_class.php'); + } + + public function testTraitPrivateConstructorCannotBeCalledFromGlobalScope(): void + { + // trait 提供的私有构造器扁平化后等价于类的私有构造器 + $this->exec('Cannot call private TestClass::__construct()', 'trait_constructor_private.php'); + } + + public function testTraitProtectedConstructorCannotBeCalledFromGlobalScope(): void + { + // trait 提供的保护构造器扁平化后等价于类的保护构造器 + $this->exec('Cannot call protected TestClass::__construct()', 'trait_constructor_protected.php'); + } + + public function testConflictingTraitConstructorMustBeResolved(): void + { + // 两个 trait 各自声明 __construct 时必须显式解决冲突 + $this->exec('Trait `TraitB` method `__construct` already exists', 'trait_constructor_conflict.php'); + } +} diff --git a/src/CompilerBase.php b/src/CompilerBase.php index c183b5a9..387b03ff 100644 --- a/src/CompilerBase.php +++ b/src/CompilerBase.php @@ -3177,6 +3177,15 @@ class CompilerBase implements PropertyAccessContext if ($classDef->flags & Modifiers::ABSTRACT) { $this->fatalError($expr, "abstract class `{$className}` cannot be instantiated"); } + // 检查构造函数可见性（private/protected 在不可访问的上下文中被调用） + $ctor = $this->findConstructor($className); + if ($ctor !== null && !$this->checkAccessible($ctor['classDef'], $ctor['flags'])) { + $this->fatalError( + $expr, + 'Cannot call ' . $this->visibilityLabel($ctor['flags']) . ' ' + . $ctor['classDef']->getNamespacedName() . '::__construct()' + ); + } } $cePtr = $this->getClassEntryPtr($className); } @@ -3859,6 +3868,39 @@ class CompilerBase implements PropertyAccessContext return true; } + /** + * 沿继承链查找定义 __construct 的类及其可见性标志。 + * 返回 ['classDef' => ClassDef, 'flags' => int]，未找到（例如构造函数定义在内部类）时返回 null。 + * + * @return array{classDef: ClassDef, flags: int}|null + */ + protected function findConstructor(string $className): ?array + { + $current = $className; + while ($current !== '' && $current !== null) { + if (!$this->hasClass($current)) { + return null; + } + $classDef = $this->getClass($current); + if ($classDef->hasMethod('__construct')) { + return ['classDef' => $classDef, 'flags' => $classDef->getMethod('__construct')->flags]; + } + $current = $classDef->extends; + } + return null; + } + + protected function visibilityLabel(int $flags): string + { + if ($flags & Modifiers::PRIVATE) { + return 'private'; + } + if ($flags & Modifiers::PROTECTED) { + return 'protected'; + } + return 'public'; + } + protected function genDebugInfo(?NodeAbstract $stmt = null, string $functionName = '', int $startLine = 0): string { $code = ''; diff --git a/tests/compiler/object_ctor/ctor-visibility-protected-subclass.phpt b/tests/compiler/object_ctor/ctor-visibility-protected-subclass.phpt new file mode 100644 index 00000000..a1db317b --- /dev/null +++ b/tests/compiler/object_ctor/ctor-visibility-protected-subclass.phpt @@ -0,0 +1,26 @@ +--TEST-- +Constructor visibility - protected constructor accessible from subclass +--FILE-- + +--EXPECT-- +bool(true) diff --git a/tests/compiler/trait/trait-ctor-basic.phpt b/tests/compiler/trait/trait-ctor-basic.phpt new file mode 100644 index 00000000..1cf76b71 --- /dev/null +++ b/tests/compiler/trait/trait-ctor-basic.phpt @@ -0,0 +1,27 @@ +--TEST-- +Trait __construct is used by the composing class +--FILE-- + +--EXPECT-- +trait ctor diff --git a/tests/compiler/trait/trait-ctor-override.phpt b/tests/compiler/trait/trait-ctor-override.phpt new file mode 100644 index 00000000..5b40f487 --- /dev/null +++ b/tests/compiler/trait/trait-ctor-override.phpt @@ -0,0 +1,32 @@ +--TEST-- +Class __construct overrides the one provided by a trait +--FILE-- + +--EXPECT-- +class ctor diff --git a/tests/compiler/trait/trait-ctor-protected-subclass.phpt b/tests/compiler/trait/trait-ctor-protected-subclass.phpt new file mode 100644 index 00000000..319fd2f3 --- /dev/null +++ b/tests/compiler/trait/trait-ctor-protected-subclass.phpt @@ -0,0 +1,37 @@ +--TEST-- +Trait protected __construct is accessible from a subclass +--FILE-- + +--EXPECT-- +base ctor +sub ctor diff --git a/tests/compiler/trait/trait-ctor-with-args.phpt b/tests/compiler/trait/trait-ctor-with-args.phpt new file mode 100644 index 00000000..5177cb28 --- /dev/null +++ b/tests/compiler/trait/trait-ctor-with-args.phpt @@ -0,0 +1,30 @@ +--TEST-- +Trait __construct with arguments and $this property access +--FILE-- +value = $value; + echo "value=" . $this->value . "\n"; + } +} + +class TestClass +{ + use TestTrait; +} + +function main() +{ + new TestClass(42); +} +?> +--EXPECT-- +value=42 From 9b1f5b79421f6a3701043988f004075248010e27 Mon Sep 17 00:00:00 2001 From: tianfenghan Date: Fri, 24 Jul 2026 16:50:25 +0800 Subject: [PATCH 4/6] fix(compiler): harden constructor visibility checks --- ...nstructor_visibility_inherited_private.php | 17 +++++ ...onstructor_visibility_internal_private.php | 6 ++ .../constructor_visibility_namespaced.php | 15 +++++ phpunit/src/ConstructorVisibilityTest.php | 23 ++++++- src/CompilerBase.php | 66 ++++++++++++------- 5 files changed, 101 insertions(+), 26 deletions(-) create mode 100644 phpunit/code/constructor_visibility_inherited_private.php create mode 100644 phpunit/code/constructor_visibility_internal_private.php create mode 100644 phpunit/code/constructor_visibility_namespaced.php diff --git a/phpunit/code/constructor_visibility_inherited_private.php b/phpunit/code/constructor_visibility_inherited_private.php new file mode 100644 index 00000000..53ace63a --- /dev/null +++ b/phpunit/code/constructor_visibility_inherited_private.php @@ -0,0 +1,17 @@ +compile($file); - } catch (TestError | \RuntimeException $exception) { + } catch (TestError|RuntimeException $exception) { $this->assertStringContainsString($expected, $exception->getMessage()); return; } @@ -37,6 +37,27 @@ class ConstructorVisibilityTest extends BaseTest $this->exec('Cannot call protected Base::__construct()', 'constructor_visibility_protected_foreign_class.php'); } + public function testInheritedPrivateConstructorCannotBeCalledFromChildScope(): void + { + $this->exec( + 'Cannot call private PrivateConstructorParent::__construct()', + 'constructor_visibility_inherited_private.php' + ); + } + + public function testInternalPrivateConstructorCannotBeCalled(): void + { + $this->exec('Cannot call private Closure::__construct()', 'constructor_visibility_internal_private.php'); + } + + public function testNamespacedConstructorUsesPhpClassNameInDiagnostic(): void + { + $this->exec( + 'Cannot call private ConstructorVisibility\Hidden::__construct()', + 'constructor_visibility_namespaced.php' + ); + } + public function testTraitPrivateConstructorCannotBeCalledFromGlobalScope(): void { // trait 提供的私有构造器扁平化后等价于类的私有构造器 diff --git a/src/CompilerBase.php b/src/CompilerBase.php index 387b03ff..5a2f709a 100644 --- a/src/CompilerBase.php +++ b/src/CompilerBase.php @@ -3172,20 +3172,17 @@ class CompilerBase implements PropertyAccessContext $className = $this->getNamespacedClassName($className); } $ctorClassName = $className; - if ($this->hasClass($className)) { - $classDef = $this->getClass($className); - if ($classDef->flags & Modifiers::ABSTRACT) { - $this->fatalError($expr, "abstract class `{$className}` cannot be instantiated"); - } - // 检查构造函数可见性（private/protected 在不可访问的上下文中被调用） - $ctor = $this->findConstructor($className); - if ($ctor !== null && !$this->checkAccessible($ctor['classDef'], $ctor['flags'])) { - $this->fatalError( - $expr, - 'Cannot call ' . $this->visibilityLabel($ctor['flags']) . ' ' - . $ctor['classDef']->getNamespacedName() . '::__construct()' - ); - } + if ($this->isAbstractClass($className)) { + $this->fatalError($expr, "abstract class `{$className}` cannot be instantiated"); + } + $constructor = $this->findConstructor($className); + if ($constructor !== null + && !$this->checkAccessibleByClassName($constructor['className'], $constructor['flags'])) { + $this->fatalError( + $expr, + 'Cannot call ' . $this->visibilityLabel($constructor['flags']) . ' ' + . $constructor['className'] . '::__construct()' + ); } $cePtr = $this->getClassEntryPtr($className); } @@ -3842,6 +3839,11 @@ class CompilerBase implements PropertyAccessContext } protected function checkAccessible(ClassDef $classDef, int $flags): bool + { + return $this->checkAccessibleByClassName($classDef->getNamespacedName(false), $flags); + } + + protected function checkAccessibleByClassName(string $declaringClass, int $flags): bool { $scopeClassDef = $this->classDef; if ($this->functionDef !== null @@ -3852,7 +3854,7 @@ class CompilerBase implements PropertyAccessContext // 私有方法，只能当前的类使用 if ($flags & Modifiers::PRIVATE) { return $scopeClassDef !== null - && strcasecmp($classDef->getNamespacedName(false), $scopeClassDef->getNamespacedName(false)) === 0; + && $this->isSameClassName($declaringClass, $scopeClassDef->getNamespacedName(false)); } // 保护方法，只能当前类和子类使用 if ($flags & Modifiers::PROTECTED) { @@ -3861,7 +3863,7 @@ class CompilerBase implements PropertyAccessContext } return $this->canAccessProtectedProperty( $scopeClassDef->getNamespacedName(false), - $classDef->getNamespacedName(false) + $declaringClass ); } // 类外部调用，只允许调用 public 方法 @@ -3869,23 +3871,37 @@ class CompilerBase implements PropertyAccessContext } /** - * 沿继承链查找定义 __construct 的类及其可见性标志。 - * 返回 ['classDef' => ClassDef, 'flags' => int]，未找到（例如构造函数定义在内部类）时返回 null。 + * 沿继承链查找实际调用的构造函数，包括项目类继承的内部类构造函数。 * - * @return array{classDef: ClassDef, flags: int}|null + * @return array{className: string, flags: int}|null */ protected function findConstructor(string $className): ?array { $current = $className; - while ($current !== '' && $current !== null) { - if (!$this->hasClass($current)) { + while ($current !== '') { + if ($this->hasClass($current)) { + $classDef = $this->getClass($current); + if ($classDef->hasMethod('__construct')) { + return [ + 'className' => $classDef->getNamespacedName(false), + 'flags' => $classDef->getMethod('__construct')->flags, + ]; + } + $current = $classDef->extends; + continue; + } + if (!$this->isInternalClass($current)) { return null; } - $classDef = $this->getClass($current); - if ($classDef->hasMethod('__construct')) { - return ['classDef' => $classDef, 'flags' => $classDef->getMethod('__construct')->flags]; + + $constructor = Reflection::getClass($current)?->getConstructor(); + if ($constructor === null) { + return null; } - $current = $classDef->extends; + return [ + 'className' => $constructor->getDeclaringClass()->getName(), + 'flags' => $constructor->getModifiers(), + ]; } return null; } From eadac69dcdcea7ff9741ac2992bfae0ba2aa0c77 Mon Sep 17 00:00:00 2001 From: tianfenghan Date: Fri, 24 Jul 2026 16:59:31 +0800 Subject: [PATCH 5/6] test(compiler): cover namespace trailing comment variants --- .../namespace_ending_comment_unbracketed.php | 14 ++++++++++++++ phpunit/src/PreprocessorTest.php | 19 +++++++++++++++++++ .../namespace/namespace-ending-comment.phpt | 4 ++-- 3 files changed, 35 insertions(+), 2 deletions(-) create mode 100644 phpunit/code/preprocessor/namespace_ending_comment_unbracketed.php diff --git a/phpunit/code/preprocessor/namespace_ending_comment_unbracketed.php b/phpunit/code/preprocessor/namespace_ending_comment_unbracketed.php new file mode 100644 index 00000000..7ad8b333 --- /dev/null +++ b/phpunit/code/preprocessor/namespace_ending_comment_unbracketed.php @@ -0,0 +1,14 @@ +assertSame('App\\VERSION', $constants['_const_var_App__VERSION']->name); } + public function testNamespaceEndingCommentWithUnbracketedSyntaxIsIgnored(): void + { + global $translator; + $file = __DIR__ . '/../code/preprocessor/namespace_ending_comment_unbracketed.php'; + $previousTranslator = $translator ?? null; + $translator = $this->compiler; + + try { + $this->compiler->addFiles([$file]); + $this->compiler->prepareFile($file); + $this->compiler->convertFile($file); + } finally { + $translator = $previousTranslator; + } + + $constants = $this->getProperty('constants'); + $this->assertArrayHasKey('_const_var_NamespaceEndingComment__VALUE', $constants); + } + public function testSortFilesUsesImplementsAndTraitDependencies(): void { $classFile = realpath(__DIR__ . '/../code/preprocessor/deps_class_implements.php'); diff --git a/tests/compiler/namespace/namespace-ending-comment.phpt b/tests/compiler/namespace/namespace-ending-comment.phpt index fa0f3da0..e937a711 100644 --- a/tests/compiler/namespace/namespace-ending-comment.phpt +++ b/tests/compiler/namespace/namespace-ending-comment.phpt @@ -6,7 +6,7 @@ A namespace block ending with a comment must not be treated as stray code declare(strict_types=1); namespace Test { - // test + /* named namespace trailing block comment */ } namespace { @@ -15,7 +15,7 @@ namespace { var_dump('done'); } - // test1 + // global namespace trailing line comment } ?> --EXPECT-- From 71caa933d6e3f4b8e2a49003ef3deb71ddd94473 Mon Sep 17 00:00:00 2001 From: tianfenghan Date: Fri, 24 Jul 2026 17:14:49 +0800 Subject: [PATCH 6/6] fix(compiler): enforce complete return covariance rules --- ...ance_error_return_intersection_missing.php | 23 ++ ...inheritance_error_return_never_widened.php | 13 ++ ...nheritance_error_return_static_widened.php | 17 ++ ...inheritance_error_return_union_widened.php | 14 ++ .../return_type_covariance_intersection.php | 39 ++++ phpunit/src/InheritanceErrorTest.php | 25 ++ src/Generator/TypeCheckGenerator.php | 2 +- src/Preprocessor.php | 4 +- src/Translator.php | 213 ++++++++++-------- .../type_decl/return-type-covariance.phpt | 69 ++++++ 10 files changed, 323 insertions(+), 96 deletions(-) create mode 100644 phpunit/code/inheritance_error_return_intersection_missing.php create mode 100644 phpunit/code/inheritance_error_return_never_widened.php create mode 100644 phpunit/code/inheritance_error_return_static_widened.php create mode 100644 phpunit/code/inheritance_error_return_union_widened.php create mode 100644 phpunit/code/return_type_covariance_intersection.php diff --git a/phpunit/code/inheritance_error_return_intersection_missing.php b/phpunit/code/inheritance_error_return_intersection_missing.php new file mode 100644 index 00000000..03ac56c2 --- /dev/null +++ b/phpunit/code/inheritance_error_return_intersection_missing.php @@ -0,0 +1,23 @@ +exec('must be compatible', 'inheritance_error_return_contravariant_class.php'); } + public function testUnionReturnTypeCannotBeWidenedToUnrelatedType(): void + { + $this->exec('must be compatible', 'inheritance_error_return_union_widened.php'); + } + + public function testIntersectionReturnTypeCannotDropAMember(): void + { + $this->exec('must be compatible', 'inheritance_error_return_intersection_missing.php'); + } + + public function testStaticReturnTypeCannotBeWidenedToSelf(): void + { + $this->exec('must be compatible', 'inheritance_error_return_static_widened.php'); + } + + public function testNeverReturnTypeCannotBeWidenedToVoid(): void + { + $this->exec('must be compatible', 'inheritance_error_return_never_widened.php'); + } + + public function testIntersectionReturnTypeCanNarrowToIntersectionOrConcreteSubtype(): void + { + $this->assertCompiles('return_type_covariance_intersection.php'); + } + public function testParameterTypeCannotBeCovariant() { $this->exec('must be compatible', 'inheritance_error_param_covariant_class.php'); diff --git a/src/Generator/TypeCheckGenerator.php b/src/Generator/TypeCheckGenerator.php index 292967a1..66dbb2e2 100644 --- a/src/Generator/TypeCheckGenerator.php +++ b/src/Generator/TypeCheckGenerator.php @@ -116,7 +116,7 @@ trait TypeCheckGenerator return $class ? [['kind' => 'instanceof', 'class' => $class]] : []; } - private function typeCheckNodeToString(NodeAbstract $typeNode): string + protected function typeCheckNodeToString(NodeAbstract $typeNode): string { if ($typeNode instanceof Node\Identifier) { return $typeNode->name; diff --git a/src/Preprocessor.php b/src/Preprocessor.php index 2d311e00..98e2bcec 100644 --- a/src/Preprocessor.php +++ b/src/Preprocessor.php @@ -542,6 +542,9 @@ class Preprocessor extends CompilerBase } $functionDef->exported = !($this->classDef?->exported === false || $this->hasNoExportAttribute($v)); $functionDef->returnClass = $class; + $functionDef->returnTypeStr = $v->returnType === null + ? '' + : $this->typeCheckNodeToString($v->returnType); // Record late-bound return type keywords so they can be re-resolved to // the consuming class when a trait method is flattened into a class. $functionDef->returnTypeKeyword = $returnTypeKeyword; @@ -560,7 +563,6 @@ class Preprocessor extends CompilerBase $typeInfo = $this->buildTypeCheckFromNode($v->returnType); if (!empty($typeInfo['check'])) { $functionDef->returnTypeCheck = $typeInfo['check']; - $functionDef->returnTypeStr = $typeInfo['typeStr']; $functionDef->returnTypeNode = $v->returnType; } } diff --git a/src/Translator.php b/src/Translator.php index 8d36035f..09ac076d 100644 --- a/src/Translator.php +++ b/src/Translator.php @@ -3624,7 +3624,12 @@ CODE; )); } - if (!$this->isReturnTypeOverrideCompatible($childFuncDef, $parentFuncDef)) { + if (!$this->isReturnTypeOverrideCompatible( + $childFuncDef, + $parentFuncDef, + $className, + $parentClass, + )) { $this->fatalMethodOverrideIncompatible($v, $className, $methodName, $parentClass); } if ($childFuncDef->returnsByRef !== $parentFuncDef->returnsByRef) { @@ -3709,143 +3714,163 @@ CODE; )); } - private function isReturnTypeOverrideCompatible(FunctionDef $childFuncDef, FunctionDef $parentFuncDef): bool - { + private function isReturnTypeOverrideCompatible( + FunctionDef $childFuncDef, + FunctionDef $parentFuncDef, + string $childClass, + string $parentClass, + ): bool { if ($parentFuncDef->returnTypeUndeclared) { return true; } if ($childFuncDef->returnTypeUndeclared) { return false; } - // A parent that accepts everything (mixed/var) is compatible with any - // child return type. - if ($parentFuncDef->returnType === Type::VAR) { - return true; - } - $parentTypes = $this->getReturnAcceptedTypes($parentFuncDef); - $childTypes = $this->getReturnAcceptedTypes($childFuncDef); + $parentTypes = $this->getReturnAcceptedTypes($parentFuncDef, $parentClass); + $childTypes = $this->getReturnAcceptedTypes($childFuncDef, $childClass); - // Return type covariance: every value the child can return must also be - // acceptable under the parent's declared return type. This allows a - // child to narrow a nullable/union return type (e.g. `?Base` -> `?Child` - // or `int|string` -> `int`) while still satisfying the parent contract. - return $this->isReturnTypeSubtype($childTypes, $parentTypes); + // Type checks are stored in disjunctive normal form: the outer list is + // a union, while an allOf entry is an intersection. Every child union + // branch must imply at least one complete parent branch. + foreach ($childTypes as $childType) { + if (!$this->isReturnTypeCoveredBy($childType, $parentTypes)) { + return false; + } + } + return true; } - private function getReturnAcceptedTypes(FunctionDef $functionDef): array + private function getReturnAcceptedTypes(FunctionDef $functionDef, string $declaringClass): array { if (!empty($functionDef->returnTypeCheck)) { - return $functionDef->returnTypeCheck; - } - $type = $functionDef->returnType; - if ($type === Type::VAR) { - return [['kind' => 'isMixed']]; - } - if ($type === Type::OBJECT) { - return $functionDef->returnClass - ? [['kind' => 'instanceof', 'class' => $functionDef->returnClass]] - : [['kind' => 'isObject']]; + return array_map( + fn (array $type): array => $this->normalizeReturnTypeEntry($type, $declaringClass), + $functionDef->returnTypeCheck, + ); } - return match ($type) { - Type::INT => [['kind' => 'isInt']], - Type::FLOAT => [['kind' => 'isFloat']], - Type::BOOL => [['kind' => 'isBool']], - Type::STR => [['kind' => 'isString']], - Type::ARRAY => [['kind' => 'isArray']], - Type::RESOURCE => [['kind' => 'isResource']], - default => [['kind' => 'isMixed']], + + if ($functionDef->returnTypeKeyword === 'static') { + return [['kind' => 'isStatic', 'class' => $declaringClass]]; + } + if ($functionDef->returnType === Type::OBJECT && $functionDef->returnClass !== '') { + return [['kind' => 'instanceof', 'class' => $functionDef->returnClass]]; + } + + $declaredType = strtolower($functionDef->returnTypeStr); + return match ($declaredType) { + 'mixed' => [['kind' => 'isMixed']], + 'never' => [['kind' => 'isNever']], + 'void' => [['kind' => 'isVoid']], + 'null' => [['kind' => 'isNull']], + 'true' => [['kind' => 'isTrue']], + 'false' => [['kind' => 'isFalse']], + 'callable' => [['kind' => 'callable']], + 'iterable' => [['kind' => 'iterable']], + 'object' => [['kind' => 'isObject']], + default => match ($functionDef->returnType) { + Type::INT => [['kind' => 'isInt']], + Type::FLOAT => [['kind' => 'isFloat']], + Type::BOOL => [['kind' => 'isBool']], + Type::STR => [['kind' => 'isString']], + Type::ARRAY => [['kind' => 'isArray']], + Type::RESOURCE => [['kind' => 'isResource']], + Type::OBJECT => [['kind' => 'isObject']], + default => [['kind' => 'isMixed']], + }, }; } - private function isReturnTypeSubtype(array $childTypes, array $parentTypes): bool + private function normalizeReturnTypeEntry(array $type, string $declaringClass): array { - foreach ($childTypes as $childType) { - if (!$this->isReturnTypeCoveredBy($childType, $parentTypes)) { - return false; - } + if (($type['kind'] ?? null) === 'allOf') { + $type['types'] = array_map( + fn (array $member): array => $this->normalizeReturnTypeEntry($member, $declaringClass), + $type['types'], + ); + } elseif (($type['kind'] ?? null) === 'instanceof' && ($type['class'] ?? null) === 'static') { + $type = ['kind' => 'isStatic', 'class' => $declaringClass]; } - return true; + return $type; } private function isReturnTypeCoveredBy(array $childType, array $parentTypes): bool { - $childKind = $childType['kind'] ?? null; + $childClause = ($childType['kind'] ?? null) === 'allOf' + ? $childType['types'] + : [$childType]; - // Child is an intersection (A&B): it is a subtype only if every member - // is individually a subtype of the parent type. - if ($childKind === 'allOf') { - foreach ($childType['types'] as $member) { - if (!$this->isReturnTypeCoveredBy($member, $parentTypes)) { - return false; - } + foreach ($parentTypes as $parentType) { + $parentClause = ($parentType['kind'] ?? null) === 'allOf' + ? $parentType['types'] + : [$parentType]; + if ($this->isReturnTypeClauseSubtype($childClause, $parentClause)) { + return true; } - return true; } + return false; + } - foreach ($parentTypes as $parentType) { - $parentKind = $parentType['kind'] ?? null; - - // Parent is an intersection (A&B): the child must be a subtype of - // every member of the intersection. - if ($parentKind === 'allOf') { - $ok = true; - foreach ($parentType['types'] as $member) { - if (!$this->isReturnTypeCoveredBy($childType, [$member])) { - $ok = false; - break; - } - } - if ($ok) { - return true; + private function isReturnTypeClauseSubtype(array $childClause, array $parentClause): bool + { + foreach ($parentClause as $parentType) { + $covered = false; + foreach ($childClause as $childType) { + if ($this->isReturnTypeEntryCompatible($childType, $parentType)) { + $covered = true; + break; } - continue; } - - if ($this->isReturnTypeEntryCompatible($childKind, $childType, $parentKind, $parentType)) { - return true; + if (!$covered) { + return false; } } - - return false; + return true; } - private function isReturnTypeEntryCompatible( - ?string $childKind, - array $childType, - ?string $parentKind, - array $parentType - ): bool { - if ($childKind === 'isNull') { - // A null value is only compatible with a nullable (isNull) parent. - return $parentKind === 'isNull'; + private function isReturnTypeEntryCompatible(array $childType, array $parentType): bool + { + $childKind = $childType['kind'] ?? null; + $parentKind = $parentType['kind'] ?? null; + + if ($childKind === 'isNever' || $parentKind === 'isMixed') { + return true; } - if ($childKind === 'isObject') { - // Any object is compatible with a parent that accepts any object. - return $parentKind === 'isObject'; + if (($childKind === 'isTrue' || $childKind === 'isFalse') && $parentKind === 'isBool') { + return true; } - if ($childKind === 'isMixed') { - return $parentKind === 'isMixed'; + if ($childKind === 'isArray' && $parentKind === 'iterable') { + return true; + } + if ($childKind === 'isStatic') { + if ($parentKind === 'isObject' || $parentKind === 'isStatic') { + return true; + } + if ($parentKind === 'instanceof') { + return $this->isInheritedFrom( + $childType['class'] ?? '', + $parentType['class'] ?? '', + ); + } + return false; } if ($childKind === 'instanceof') { if ($parentKind === 'isObject') { return true; } + $childClass = $childType['class'] ?? ''; + if ($parentKind === 'iterable') { + return $childClass !== '' && $this->isInheritedFrom($childClass, 'Traversable'); + } if ($parentKind === 'instanceof') { - $childClass = $childType['class'] ?? ''; $parentClass = $parentType['class'] ?? ''; - if ($childClass === '' || $parentClass === '' || $childClass === 'static' || $parentClass === 'static') { - return false; - } - if ($childClass === $parentClass) { - return true; - } - return $this->isInheritedFrom($childClass, $parentClass); + return $childClass !== '' + && $parentClass !== '' + && $this->isInheritedFrom($childClass, $parentClass); } return false; } - // Scalar kinds must match exactly. - return $childKind === $parentKind; + return $childKind !== null && $childKind === $parentKind; } private function isParameterTypeOverrideCompatible(ArgInfo $childArg, ArgInfo $parentArg): bool diff --git a/tests/compiler/type_decl/return-type-covariance.phpt b/tests/compiler/type_decl/return-type-covariance.phpt index 3de3e6bb..68883ac3 100644 --- a/tests/compiler/type_decl/return-type-covariance.phpt +++ b/tests/compiler/type_decl/return-type-covariance.phpt @@ -34,6 +34,61 @@ class ObjectReturnImpl implements ObjectReturnContract } } +class StaticBase +{ + public function copy(): ?self + { + return $this; + } +} + +class StaticChild extends StaticBase +{ + public function copy(): ?static + { + return $this; + } +} + +interface IterableContract +{ + public function values(): iterable; +} + +class IterableImpl implements IterableContract +{ + public function values(): array + { + return [1, 2]; + } +} + +interface BoolContract +{ + public function enabled(): bool; +} + +class LiteralBoolImpl implements BoolContract +{ + public function enabled(): true + { + return true; + } +} + +abstract class VoidContract +{ + abstract public function stop(): void; +} + +abstract class NeverImpl extends VoidContract +{ + public function stop(): never + { + throw new RuntimeException('stop'); + } +} + function main() { $impl = new UnionReturnImpl(); @@ -43,9 +98,23 @@ function main() $built = $obj->build(); var_dump($built instanceof BaseType); var_dump($built instanceof ChildType); + + $static = new StaticChild(); + var_dump($static->copy() instanceof StaticChild); + + var_dump((new IterableImpl())->values()); + var_dump((new LiteralBoolImpl())->enabled()); } ?> --EXPECT-- int(42) bool(true) bool(true) +bool(true) +array(2) { + [0]=> + int(1) + [1]=> + int(2) +} +bool(true)