fix(static-analysis): resolve high-value type issues

bin/dump-ast.php

@@ -189,11 +189,12 @@ function printNodeArray(array $arr, string $indent, int|string $key): void
 
 function printNodeAttrs(array $arr, string $indent): void
 {
+    $type = $arr['type'];
     $hasAttrs = !empty($arr['attributes']);
     $attrs    = $arr['attributes'] ?? [];
     unset($arr['type'], $arr['attributes']);
 
-    echo $indent . "type: " . $arr['type'] . "\n";
+    echo $indent . "type: " . $type . "\n";
     echo $indent . "lines: " . $attrs['startLine'] . '-' . $attrs['endLine'] . "\n";
 
     if (isset($attrs['comments'])) {

src/Analysis/SsaBuilder.php

@@ -42,7 +42,7 @@ class SsaVar
     public int $flags = 0;
 
     /** The AST node where this variable was defined (Assign, Param, etc.) */
-    public ?NodeAbstract $definition = null;
+    public ?Node $definition = null;
 
     /** Type constraint from instanceof/type-check conditions (e-SSA pi node) */
     public ?PiConstraint $pi = null;
@@ -184,7 +184,7 @@ class SsaBuilder
     /** @var array Parameter byRef flags: paramName => bool */
     private array $paramByRef = [];
 
-    /** @var array<string, string> goto label → block ID */
+    /** @var array<string, int> goto label → block ID */
     private array $labelBlocks = [];
 
     /** @var int The entry block ID */
@@ -348,13 +348,10 @@ class SsaBuilder
      */
     private function splitIntoBlocks(array $stmts): array
     {
-        $blocks = [];
         $currentBlock = $this->newBlock();
-        if (empty($blocks)) {
-            $currentBlock->id = 0;
-            $this->entryBlockId = 0;
-        }
-        $blocks[] = $currentBlock;
+        $currentBlock->id = 0;
+        $this->entryBlockId = 0;
+        $blocks = [$currentBlock];
 
         $this->splitStmtList($stmts, $blocks, $currentBlock);
 

src/Assert.php

@@ -759,7 +759,7 @@ class Assert
         $valid = isset($value[0]);
 
         if ($valid) {
-            $locale = setlocale(LC_CTYPE, 0);
+            $locale = setlocale(LC_CTYPE, '0');
             setlocale(LC_CTYPE, 'C');
             $valid = ctype_alpha($value[0]);
             setlocale(LC_CTYPE, $locale);
@@ -816,7 +816,7 @@ class Assert
 
     public static function alpha($value, $message = ''): bool
     {
-        $locale = setlocale(LC_CTYPE, 0);
+        $locale = setlocale(LC_CTYPE, '0');
         setlocale(LC_CTYPE, 'C');
         $valid = !ctype_alpha($value);
         setlocale(LC_CTYPE, $locale);
@@ -833,7 +833,7 @@ class Assert
 
     public static function digits($value, $message = ''): bool
     {
-        $locale = setlocale(LC_CTYPE, 0);
+        $locale = setlocale(LC_CTYPE, '0');
         setlocale(LC_CTYPE, 'C');
         $valid = !ctype_digit($value);
         setlocale(LC_CTYPE, $locale);
@@ -850,7 +850,7 @@ class Assert
 
     public static function alnum($value, $message = ''): bool
     {
-        $locale = setlocale(LC_CTYPE, 0);
+        $locale = setlocale(LC_CTYPE, '0');
         setlocale(LC_CTYPE, 'C');
         $valid = !ctype_alnum($value);
         setlocale(LC_CTYPE, $locale);
@@ -867,7 +867,7 @@ class Assert
 
     public static function lower($value, $message = ''): bool
     {
-        $locale = setlocale(LC_CTYPE, 0);
+        $locale = setlocale(LC_CTYPE, '0');
         setlocale(LC_CTYPE, 'C');
         $valid = !ctype_lower($value);
         setlocale(LC_CTYPE, $locale);
@@ -884,7 +884,7 @@ class Assert
 
     public static function upper($value, $message = ''): bool
     {
-        $locale = setlocale(LC_CTYPE, 0);
+        $locale = setlocale(LC_CTYPE, '0');
         setlocale(LC_CTYPE, 'C');
         $valid = !ctype_upper($value);
         setlocale(LC_CTYPE, $locale);
@@ -1387,4 +1387,4 @@ class Assert
     }
 }
 
-class_alias(Assert::class, 'Assert');
+class_alias(Assert::class, 'Assert');

src/CompilerBase.php

@@ -275,6 +275,7 @@ class CompilerBase implements PropertyAccessContext
     protected const string PHASE_CONVERT = 'convert';
 
     protected string $lang = 'PHP';
+    protected bool $verbose = false;
     protected int $indentLevel = 0;
     protected string $indentStr = "\t";
     public string $mode = 'cli';

src/Entity/ClassDef.php

@@ -177,6 +177,6 @@ class ClassDef extends ClassLikeDef
 
     public function isAbstract(): bool
     {
-        return $this->flags & Modifiers::ABSTRACT;
+        return ($this->flags & Modifiers::ABSTRACT) !== 0;
     }
 }

src/Entity/PropertyDef.php

@@ -52,12 +52,12 @@ class PropertyDef
 
     public function isPrivate(): bool
     {
-        return $this->flags & Modifiers::PRIVATE;
+        return ($this->flags & Modifiers::PRIVATE) !== 0;
     }
 
     public function isProtected(): bool
     {
-        return $this->flags & Modifiers::PROTECTED;
+        return ($this->flags & Modifiers::PROTECTED) !== 0;
     }
 
     public function isPublic(): bool
@@ -67,7 +67,7 @@ class PropertyDef
 
     public function isStatic(): bool
     {
-        return $this->flags & Modifiers::STATIC;
+        return ($this->flags & Modifiers::STATIC) !== 0;
     }
 
     public function isReadonly(): bool

src/Generator/AnonClassGenerator.php

@@ -125,7 +125,7 @@ trait AnonClassGenerator
     /**
      * Resolve a single type node, converting relative Name to FullyQualified.
      */
-    protected function resolveTypeNode(Node $type): NodeAbstract
+    protected function resolveTypeNode(Node\ComplexType|Identifier|Name $type): Node\ComplexType|Identifier|Name
     {
         if ($type instanceof Name) {
             if ($type->isFullyQualified()) {

src/Optimizer/FuncCallOptimizer.php

@@ -900,7 +900,7 @@ trait FuncCallOptimizer
                 return '(' . $argInfo->name . '.count() + ' . $i . ')';
             }
         }
-        return count($funcDef->argInfoList);
+        return (string) count($funcDef->argInfoList);
     }
 
     protected function genFunctionExists(string $name, Node\Expr\FuncCall $expr, array $config): string

src/Preprocessor.php

@@ -46,6 +46,8 @@ use PhpParser\NodeVisitor\NameResolver;
 
 class Preprocessor extends CompilerBase
 {
+    protected string $targetName = 'app';
+
     /**
      * Discover Native class names before parsing any signatures or fields.
      *

src/Translator.php

@@ -71,13 +71,11 @@ class Translator extends Preprocessor
     public const string VERSION = '0.6.6';
     public const string APP_NAME = 'TypePHP Compiler (AOT)';
 
-    protected string $targetName = 'app';
     protected bool $hasExplicitOutput = false;
     protected ?string $explicitOutputExtension = null;
     protected array $sourceDirs = [];
     private ?ProjectYamlLoader $projectYamlLoader = null;
     private ?NativeBuilder $nativeBuilder = null;
-    protected bool $verbose = false;
     protected array $ignorePaths = [];
     protected array $argInfoHeaderFiles = [];
     protected array $registerSymbols = [];