Tag: Branch: Tree: 7623d367ed

master

speed_build

v0.0.1

v0.0.2

v0.0.3

v0.0.4

v0.0.5

v0.0.6

v0.0.7

v0.1.0

v0.4.0

v0.4.1

v0.6.1

v0.6.2

v0.6.5

v0.6.6

v0.6.8

v0.7.0

v0.8.0

Branches Tags

${ item.name }

Create tag ${ searchTerm }

Create branch ${ searchTerm }

from '7623d367ed'

${ noResults }

Commit Graph

1 Commits (7623d367edc611712204859ed76da70c750e388f)

Author	SHA1	Message	Date
Alessio Giacobbe	26bfbdda4e	fix(translator): constructor, private-method and abstract redeclaration override rules (#56) --skip-tests ... * fix(translator): enforce final and abstract parent constructor rules checkParentMethodCanBeOverridden() returned immediately for __construct, so overriding a FINAL parent constructor was accepted (Zend: "Cannot override final method A::__construct()") and an ABSTRACT parent constructor's signature was never validated (Zend checks it exactly like an interface constructor). Zend's constructor rules (zend_do_inheritance): - a concrete parent constructor imposes no signature contract: the child may change parameters and even narrow visibility — this exemption is kept; - a private parent constructor may be redeclared freely, but FINAL still wins: `final private function __construct()` cannot be overridden (constructors are the one place PHP allows final private); - an abstract parent constructor's signature is a real contract. Keep walking the parent chain for constructors, skipping only the private-override error and the concrete-signature validation; final checks (userland and built-in parents) and abstract-constructor validation now run. * fix(translator): allow redeclaring a parent's private method checkParentMethodCanBeOverridden() fataled with "Cannot override private method" when a child declared a method whose nearest parent declaration is PRIVATE. Zend inherits no private methods: a child may redeclare one with any signature, visibility or staticness, and FINAL is ignored on non-constructor private methods (declaring one only raises "Private methods cannot be final..."). Only the final private CONSTRUCTOR remains protected, which the constructor path already enforces. Dispatch stays correct after removing the fatal: - canDevirtualize() (Parser/MethodCallTrait) devirtualizes any call whose resolved method is private to the DECLARING class's body. That is exactly PHP's private-scope binding (zend_std_get_method prefers the calling scope's private copy), verified against the manual's Bar/Foo::testPrivate example; - method resolution walks from the receiver's static class, so code in the child binds the child's redeclaration; - a call on a receiver statically typed as the declaring class from OUTSIDE its scope is rejected by getNativeMethod()'s accessibility check, and dynamically typed receivers go through Zend dispatch; - Native (C++) classes give private methods no virtual slot (isNativeVirtualMethod() excludes PRIVATE), so no C++ override can reroute a parent's internal private call. The two tests asserting the old fatal encoded rejects-valid programs (both run fine under Zend 8.4, printing the parent's private result); they now assert successful compilation. * fix(translator): validate abstract method redeclarations against the parent chain An abstract method declared by a class was never checked against its parent: turning a concrete inherited method abstract compiled (Zend: "Cannot make non abstract method A::f() abstract in class B"), and an abstract redeclaration of an inherited abstract contract skipped the signature check entirely. Both now run through checkParentMethodCanBeOverridden with a childIsAbstract mode, covering userland and built-in parents. Trait-originated abstract requirements are exempt: Zend lets an inherited concrete method satisfy them, so only abstract methods the class itself declares participate. --------- Co-authored-by: tianfenghan <rango@swoole.com>	1 month ago