Tag: Branch: Tree: ee69e75f4f

master

speed_build

v0.0.1

v0.0.2

v0.0.3

v0.0.4

v0.0.5

v0.0.6

v0.0.7

v0.1.0

v0.4.0

v0.4.1

v0.6.1

v0.6.2

v0.6.5

v0.6.6

v0.6.8

v0.7.0

v0.8.0

Branches Tags

${ item.name }

Create tag ${ searchTerm }

Create branch ${ searchTerm }

from 'ee69e75f4f'

${ noResults }

Commit Graph

1 Commits (ee69e75f4f3b68572c81a2e25d6b111741212212)

Author	SHA1	Message	Date
Alessio Giacobbe	c578b1d6b0	fix(preprocessor): enforce property-hook placement rules for class properties (#63) --skip-tests ... * fix(preprocessor): enforce property-hook placement rules for class properties The interface path already validated hook placement; class and trait properties accepted every combination. parseClassPropertyDef now mirrors Zend's compile-time rules (probed on 8.4.13, including the precedence order static -> readonly -> abstract rules): - hooks on a static property ("Cannot declare hooks for static property") - hooks on a readonly property, including properties made readonly by a `readonly class` ("Hooked properties cannot be readonly") - `abstract` on a hook-less property ("Only hooked properties may be declared abstract") - abstract hooked property with a default value ("Cannot specify default value for virtual hooked property A::$x") - abstract hooked property whose hooks all have bodies ("Abstract property A::$x must specify at least one abstract hook") - abstract hooked property in a non-abstract class; traits stay exempt (the consuming class satisfies the hook) and enums are already rejected by the property ban - bodiless hook on a non-abstract property, in classes and traits ("Non-abstract property hook must have a body"); previously the lowering fabricated a concrete backing-store accessor for it * test(preprocessor): cover property-hook placement rules * fix(preprocessor): reject abstract-private, abstract-final and final-private hooks Three hook-level modifier conflicts Zend rejects at compile time were still accepted by the class/trait property path (all probed on 8.4.13): - `abstract private int $x { get; }` — an abstract (bodiless) hook must be implemented by a subclass, which private visibility forbids ("Property hook cannot be both abstract and private"). Unlike abstract private trait methods, Zend does NOT exempt traits from this rule. - `abstract public int $x { final get; }` — a bodiless hook must stay overridable to ever gain a body ("Property hook cannot be both abstract and final"). - `private int $x { final get => 1; }` — a final hook on a private property is meaningless because private members cannot be overridden ("Property hook cannot be both final and private"). Diagnostic precedence follows Zend: static, then readonly, then the per-hook final+private conflict (which wins over both abstract conflicts: `abstract private int $x { final get; }` reports final+private), then per bodiless hook abstract+private before abstract+final, all ahead of the default-value and at-least-one-abstract-hook rules. Protected abstract hooks remain legal in classes and traits.	1 month ago