Tag: Branch: Tree: f63eab17a3

master

speed_build

v0.0.1

v0.0.2

v0.0.3

v0.0.4

v0.0.5

v0.0.6

v0.0.7

v0.1.0

v0.4.0

v0.4.1

v0.6.1

v0.6.2

v0.6.5

v0.6.6

v0.6.8

v0.7.0

v0.8.0

Branches Tags

${ item.name }

Create tag ${ searchTerm }

Create branch ${ searchTerm }

from 'f63eab17a3'

${ noResults }

Commit Graph

1 Commits (f63eab17a353b0c8276d4a5f903296a4793aafb7)

Author	SHA1	Message	Date
Alessio Giacobbe	e90d6246ec	fix: enforce interface declaration and merge rules (#59) --skip-tests ... * fix(preprocessor): enforce Zend interface member declaration rules parseInterface accepted several declarations Zend rejects at compile time (all wordings probed on 8.4.13, which renamed the modifier errors to "must not be abstract/final"): - interface method with a body ("Interface function I::f() cannot contain body") - private/protected interface method ("Access type for interface method I::f() must be public") - explicit `abstract` modifier on an interface method ("Interface method I::f() must not be abstract") - `final` interface method ("Interface method I::f() must not be final") - private/protected interface constant ("Access type for interface constant I::X must be public"); `final` interface constants remain legal per PHP 8.1 - explicit `abstract` on an interface hooked property ("Property in interface cannot be explicitly abstract...") - `interface I extends A` where A is a known class, enum, or trait ("I cannot implement A - it is not an interface"); only checked when A's declaration has already been prepared - a parent declared later is left to the Translator (deferred to integrator) - the same interface listed twice in extends ("Interface I cannot implement previously implemented interface A") Zend's precedence for combined modifier violations (visibility, then abstract, then final, then body) is preserved. * fix(translator): validate same-name methods when interfaces merge Two interfaces declaring the same method were never cross-checked: `interface J extends I1, I2` and a class implementing both compiled even when the declarations were mutually incompatible (Zend: "Declaration of I1::f(): int must be compatible with I2::f(): string"). The first-seen declaration is now validated as an override of every later one, mirroring Zend's merge order; diamond inheritance of one original declaration never conflicts, and a method the class chain defines silences the pairwise check (it is validated against each interface individually instead) — all probed against Zend 8.4. * fix(translator): reject an interface extending a class, validate merged methods An interface can only extend other interfaces: naming a class either fataled with a misleading missing-symbol message (declaration seen earlier) or compiled silently (declaration appearing later). The translation phase now rejects both with Zend's wording. Same-name methods arriving from several extended interfaces (or from several interfaces a class implements without defining the method) were never cross-checked; the first-seen declaration is now validated as an override of every later one, matching Zend's merge order, with diamond inheritance of one original declaration exempt. * fix(translator): guard the interface method table against extends cycles getEffectiveInterfaceMethodTable() recursed forever on a cyclic extends graph (interface A extends B; interface B extends A). Zend never reaches this state - declarations are linked one at a time, so the first one already fails with 'Interface "B" not found' - but ahead-of-time the whole graph exists before linking, so the cycle must be detected. Track the tables being built in a visiting set (cleared with try/finally) and fail promptly with the same stable diagnostic the constants table uses ('Interface inheritance cycle detected at ...'), so the helper is safe regardless of which validation pass reaches the cycle first. Diamond (non-cyclic) graphs still converge through the memoized table. Covered by a negative test on the two-interface cycle; the diamond case is already exercised by interface_collision_valid.php.	1 month ago